This repository has been archived by the owner on May 14, 2024. It is now read-only.
fix complete upload crash- on localstrorage write fail #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavkgrd
changed the title
Deploying with
|
| Latest commit: |
dd0a85e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7e851a0.bada-frame.pages.dev |
| Branch Preview URL: | https://fix-complete-upload-fail.bada-frame.pages.dev |
|
Here, will the user see on the UI which file failed to upload? |
|
yep, we will show the file in the |
ua741
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is to fix the Neeraj bhaiya issue of upload crashing with a generic upload message
so, we don't let the single file error bubble up, we just log and add it to the progress bar view
Test Plan
tested locally