This repository has been archived by the owner on May 14, 2024. It is now read-only.
handle file metadata extraction failure gracefully #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
cc48cd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de51998f.bada-frame.pages.dev |
| Branch Preview URL: | https://handle-file-hash-generation-.bada-frame.pages.dev |
rushitote
previously approved these changes
Jul 27, 2022
|
@rushitote resolved merge conflicts |
rushitote
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://sentry.ente.io/organizations/ente/issues/2571/?project=2&query=is%3Aunresolved&statsPeriod=14d
added try-catch block to prevent metadata extraction error to bubble up and cause complete
extractFileTypeAndMetadatato fail and just log and returnnullas the value for metadataand later in the
uploaderthe file will be rejected accordingly with the errorNO_METADATAinstead ofCannot read properties of null (reading 'fileType')Test Plan
tested locally