Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline type annotations to dynamically generated modules #400

Closed
junkmd opened this issue Dec 11, 2022 · 0 comments · Fixed by #490
Closed

Add inline type annotations to dynamically generated modules #400

junkmd opened this issue Dec 11, 2022 · 0 comments · Fixed by #490
Labels
typing related to Python static typing system
Milestone

Comments

@junkmd
Copy link
Collaborator

junkmd commented Dec 11, 2022

In #327, we were planning to implement a feature to generate a .pyi file with its type hints as soon as the module is generated by client.GetModule.

However, with a suggestion from @kdschlosser, we shifted to generating modules with inline type annotations.

Inline type annotations are only available in Python 3.x and later, so the merge destination for the contributions is drop_py2 branch.

As planned in #392, we will support Python3.7 and later versions, so type hinting should be done in the way supported from 3.7 and earlier.
For example...

This kanban will be updated as the situation requires.

Any opinions would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing related to Python static typing system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant