Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client.dynamic._Dispatch.QueryInterface #441

Closed
junkmd opened this issue Jan 1, 2023 · 1 comment · Fixed by #442
Closed

fix client.dynamic._Dispatch.QueryInterface #441

junkmd opened this issue Jan 1, 2023 · 1 comment · Fixed by #442
Assignees
Labels
drop_py2 dev based on supporting only Python3, see #392
Milestone

Comments

@junkmd
Copy link
Collaborator

junkmd commented Jan 1, 2023

THIS IS FOR drop_py2 PLAN! Please see #392.

The client.dynamic._Dispatch.QueryInterface is currently only allowed to be passed a variable argument.

def QueryInterface(self, *args):
"QueryInterface is forwarded to the real com object."
return self._comobj.QueryInterface(*args)

However, this is a wrapper method for IUnknown.QueryInterface, so I want to change it to a similar argument.

def QueryInterface(self, interface, iid=None):

It does not change the name of the named arguments that were existing, so I don't think it will break backward compatibility.

@junkmd junkmd added the drop_py2 dev based on supporting only Python3, see #392 label Jan 1, 2023
@junkmd junkmd added this to the 1.3.0 milestone Jan 1, 2023
@junkmd
Copy link
Collaborator Author

junkmd commented Jan 1, 2023

I will work on this.

@junkmd junkmd self-assigned this Jan 1, 2023
@junkmd junkmd linked a pull request Jan 1, 2023 that will close this issue
@junkmd junkmd closed this as completed Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drop_py2 dev based on supporting only Python3, see #392
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant