Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotations to client.dynamic #443

Closed
junkmd opened this issue Jan 1, 2023 · 1 comment · Fixed by #444
Closed

add type annotations to client.dynamic #443

junkmd opened this issue Jan 1, 2023 · 1 comment · Fixed by #444
Assignees
Labels
drop_py2 dev based on supporting only Python3, see #392 good first issue Good for newcomers

Comments

@junkmd
Copy link
Collaborator

junkmd commented Jan 1, 2023

THIS IS FOR drop_py2 PLAN! Please see #392.

It can be only a part of the codebase, but a module as size as `client.dynamic' can probably do it all at once.

Some of them may be difficult to clearly define type annotations for.
In that case, please do not change that part and write the reason in the PR kanban.
The maintainer or this issue assignee should submit a separate issue for that task only.

@junkmd junkmd added drop_py2 dev based on supporting only Python3, see #392 good first issue Good for newcomers labels Jan 1, 2023
@junkmd junkmd self-assigned this Jan 1, 2023
@junkmd
Copy link
Collaborator Author

junkmd commented Jan 1, 2023

I created this issue to serve as a "model case" for future good first issue that I will submit.

I will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drop_py2 dev based on supporting only Python3, see #392 good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant