Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ProgressCancelled exception #445

Closed
mdickinson opened this issue Jul 19, 2021 · 1 comment · Fixed by #449
Closed

Rename ProgressCancelled exception #445

mdickinson opened this issue Jul 19, 2021 · 1 comment · Fixed by #449
Milestone
Release 0.3.0

Comments

@mdickinson
Copy link
Member

(related: #437, #317)

The ProgressCancelled exception is generally useful, and should be renamed to Cancelled and moved into base_future.py. The renaming would be best done before the 0.3.0 release, since ProgressCancelled hasn't yet been made available in any released version of the library.
@mdickinson mdickinson added this to the Release 0.3.0 milestone Jul 19, 2021
@mdickinson mdickinson changed the title Rename ProgressCancelled exception to Cancelled Rename ProgressCancelled exception Jul 20, 2021
@mdickinson
Copy link
Member Author

TaskCancelled might also work as the new name. It just needs to be something that can be used for all background tasks, not just the progress task.

This was referenced Jul 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.3.0
1 participant
@mdickinson