Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ziti's Prometheus scrape endpoint #51

Closed
qrkourier opened this issue Feb 22, 2024 · 3 comments
Closed

Ziti's Prometheus scrape endpoint #51

qrkourier opened this issue Feb 22, 2024 · 3 comments

Comments

@qrkourier
Copy link

Proposal

This might be interesting too since you're using Prometheus: https://openziti.io/docs/learn/core-concepts/metrics/prometheus/#ziti-configuration

@mjtrangoni
Copy link
Member

@qrkourier I was looking at this, and wondering how you can change the controller config from the helm values.yaml file? Is it currently feasible?

@qrkourier
Copy link
Author

We started with a Helm chart that provides reasonable defaults with minimal input values. Now I think we should provide an empty dictionary value for each controller and router top-level config sections, e.g., identity-additional-values. These optional values would be transcluded in the rendering of the config.yml.

The "additional values" approach allows the Helm user to provide arbitrary configuration but does not avoid the need to give the minimal values that are currently required.

@mjtrangoni
Copy link
Member

closing this, as now the ziti-controller helm chart brings its own servicemonitor manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants