Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better text/plain version of the summary email #109

Open
bzg opened this issue Aug 17, 2019 · 6 comments
Open

Better text/plain version of the summary email #109

bzg opened this issue Aug 17, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bzg
Copy link
Member

bzg commented Aug 17, 2019

Problem: the text/plain version could be more readable

When emails are both in text/plain and text/html, my email client displays the text/plain version by default. The text/plain version of ma-semaine emails is not as readable as it could be.

Don't use markdown and utf-8 emojis

  1. Use plain text formatting instead of markdown for text/plain: e.g. replace ** by *, etc.
  2. Use a old school plain/text smileys instead of utf-8 emojis.

Other people might need this

Since this application is likely to be used by developers and because some of them are likely to display text/plain versions of emails, this could be a real plus.

@AntoineAugusti AntoineAugusti added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2019
@AntoineAugusti
Copy link
Member

Thanks for the report. It's not a major issue because it doesn't concern a majority of users and can be resolved through configuration. The layout doesn't seem too much broken for now in plain text.

Can you share a screenshot to see what it looks like?

@bzg
Copy link
Member Author

bzg commented Aug 19, 2019

Thanks for the feedback. Here you go:

2019-08-19-104533_1920x1080_scrot

The question is: why using markdown in plain text? Is it something you need to let users add some formatting?

@AntoineAugusti
Copy link
Member

AntoineAugusti commented Aug 19, 2019

The email view is written in Markdown and rendered in HTML by Laravel. It seems Laravel sends the unrendered version of the Markdown source as the plain text version for the email.

@bzg
Copy link
Member Author

bzg commented Aug 19, 2019

Ah, ok. I guess nobody cares about plain text enough to tell Laravel to DTRT.

@AntoineAugusti
Copy link
Member

I'd say is not too bad as it is! Doing automatically another thing would require a decent amount of code and would be subjective.

@bzg
Copy link
Member Author

bzg commented Aug 19, 2019

I disagree on the "subjective": there is a text/markdown MIME type, and using markdown in text/plain is surprising. But let's agree to disagree :) I understand this is too much code for just one guy (for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants