Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not all features are used #22

Closed
claudehang opened this issue Jul 15, 2019 · 1 comment
Closed

Why not all features are used #22

claudehang opened this issue Jul 15, 2019 · 1 comment

Comments

@claudehang
Copy link

Hi,
Thanks for your code. I notice that the features for training are as:

return [store_open,
            store_index,
            day_of_week,
            promo,
            year,
            month,
            day,
            store_data[store_index - 1]['State']
            ]

but there are lots of other features like in store.csv:

Assortment | CompetitionDistance | CompetitionOpenSinceMonth | CompetitionOpenSinceYear

Could you share the consideration why you not using these as features? Thx!

@entron
Copy link
Owner

entron commented Jul 20, 2019

Sorry for the late response. The master branch is a simplified version used by the paper. All features are used in the kaggle branch: https://github.com/entron/entity-embedding-rossmann/tree/kaggle

@entron entron closed this as completed Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants