Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pan operation is not bounded #41

Closed
tlvenn opened this issue Jan 4, 2022 · 2 comments
Closed

Pan operation is not bounded #41

tlvenn opened this issue Jan 4, 2022 · 2 comments

Comments

@tlvenn
Copy link

tlvenn commented Jan 4, 2022

When the graph permits it and you can pan the graph, you can actually pan way out of it, ideally it should be bounded by its data.
image

@entronad
Copy link
Owner

entronad commented Jan 4, 2022

One of the philosophy of Graphic is trying to make everything customizable. The update functions are such cases.
But we still hope to provide default settings for easy usage, such as the Defaults.horizontalRangeSignal.
So if you need some special limits, just copy and modify the Defaults.horizontalRangeSignal code to make your own callback.

By the way I think to limit the panning is a good idea, I shall add it to the Defaults.horizontalRangeSignal.

@tlvenn
Copy link
Author

tlvenn commented Jan 4, 2022

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants