Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with KB/ČS gpc format #4

Open
MartinMystikJonas opened this issue Nov 8, 2021 · 1 comment
Open

Incompatible with KB/ČS gpc format #4

MartinMystikJonas opened this issue Nov 8, 2021 · 1 comment

Comments

@MartinMystikJonas
Copy link

Hello @enumag and @arosis. We used original JakubZaplatal package bud encountered some orrors during upgrade so we want to switch to your version here.

But we found out that you use specific ČSOB gpc format which includes currency info in transaction line (possition 118). This section is used for different purposes by different banks. So parsing of GPC by KB or Česká spořitelna will fail.

I can prepare PR with fix. I propose create specific Prser\ABO\CsobCzParser class with currency parsing logic that is currently in universal ABOParser. It would be BC break for people using universal parser and needs currency. Is that ok?

@enumag
Copy link
Owner

enumag commented Nov 8, 2021

Sure but do it at https://github.com/ifm24/bank-statements. We moved the repository under the company account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants