Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harness tests don't show expected "integration tests" mode logs #688

Closed
yaronya opened this issue Aug 10, 2023 · 3 comments · Fixed by #689
Closed

Harness tests don't show expected "integration tests" mode logs #688

yaronya opened this issue Aug 10, 2023 · 3 comments · Fixed by #689
Assignees
Labels

Comments

@yaronya
Copy link
Contributor

yaronya commented Aug 10, 2023

Refers to the code added in #578
If you run harness tests in GH action while turning INTEGRATION_TEST mode on - you'd see only the logs performed by the harness.go file and wouldn't see any other logs (for example, the ones that are performed by provider.go)

It may have to do with the fact that the harness tests and TF aren't running on the same process.

@yaronya yaronya added this to To do in Ongoing Issues via automation Aug 10, 2023
@TomerHeber
Copy link
Collaborator

@yaronya - I think this was always the case.
Only on failure would it show logs.

Is the ask to change that?

@TomerHeber
Copy link
Collaborator

If yes... which log level would we like to show?

@yaronya
Copy link
Contributor Author

yaronya commented Aug 13, 2023

We haven't seen any logs - for either failure or non-failure

I think we'd like to always see these logs in case INTEGRATION_TESTS is turned on - we get failures and we don't know if the test retried or not.
Let's start with INFO log level - we could always change that later on.

@TomerHeber TomerHeber moved this from To do to In progress in Ongoing Issues Aug 13, 2023
Ongoing Issues automation moved this from In progress to Done Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants