Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Serverless Application Model (SAM) templates #176

Closed
skatsuta opened this issue Apr 27, 2017 · 6 comments
Closed

Support Serverless Application Model (SAM) templates #176

skatsuta opened this issue Apr 27, 2017 · 6 comments

Comments

@skatsuta
Copy link
Contributor

skatsuta commented Apr 27, 2017

CloudFormation supports Serverless Application Model (SAM) templates, but when we use a SAM template StackMaster returns the following error:

$ stack_master apply
...
...
No stack found
Create stack (y/n)?
Uploading files to S3:
...
Aws::CloudFormation::Errors::ValidationError CreateStack cannot be used with templates containing Transforms.

This is because CreateStack API does not support SAM templates.
Instead, we need to use a change set to create a SAM-based stack.
So it'd be great if StackMaster supports SAM templates.

@skatsuta
Copy link
Contributor Author

Blocker is #177.

@skatsuta
Copy link
Contributor Author

skatsuta commented May 6, 2017

Merging both #178 and #179 will support this feature.

@patrobinson
Copy link
Contributor

I've released verison 0.16.0 which includes the above PRs

@skatsuta
Copy link
Contributor Author

Great! I confirmed the version works fine with SAM. Thank you for your support!

@tanyajajodia
Copy link

Hi @skatsuta - Does StackMaster support the aws cloudformation package step as well for SAM templates?

I get the following error when I try to create a stack directly using stack_master apply:
Transform AWS::Serverless-2016-10-31 failed with: Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [GraphQL] is invalid. 'CodeUri' is not a valid S3 Uri of the form "s3://bucket/key" with optional versionId query parameter.

@patrobinson
Copy link
Contributor

@tanyajajodia sorry for the late reply. No we don't currently support that step, it must be done before StackMaster is invoked.
I'd be happy to include such functionality in the future, at present we are just using plain old SAM, but it'd be nice to directly integrate it with StackMaster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants