Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove *QueryFilter workaround #223

Open
morremeyer opened this issue Jul 17, 2022 · 1 comment
Open

Remove *QueryFilter workaround #223

morremeyer opened this issue Jul 17, 2022 · 1 comment
Labels
enhancement New feature or improvements to an existing one

Comments

@morremeyer
Copy link
Member

morremeyer commented Jul 17, 2022 •
edited
Loading

Currently, there is a controllers.*QueryFilter struct for each resource type.

This is needed to bind the e.g. BudgetID to a string and then marshal it into a UUID.

Once gin-gonic/gin#3045 is merged, this struct can be removed and the tags merged into the tags of the controllers.*Editable struct of the respective resource type, adding marshalling as by the documentation that the PR adds.
@morremeyer morremeyer added the enhancement New feature or improvements to an existing one label Jul 17, 2022
@morremeyer morremeyer mentioned this issue Jul 17, 2022
Merged
@morremeyer morremeyer added the blocked This issue is blocked by something label Jan 18, 2024
@morremeyer
Copy link
Member Author

This is unblocked with #1035

@morremeyer morremeyer removed the blocked This issue is blocked by something label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvements to an existing one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morremeyer