Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcAtmosCorr(): DOS4 not implemented #38

Open
fdetsch opened this issue Apr 9, 2020 · 0 comments
Open

calcAtmosCorr(): DOS4 not implemented #38

fdetsch opened this issue Apr 9, 2020 · 0 comments
Assignees
@tnauss
Labels
help wanted

Comments

@fdetsch
Copy link
Contributor

fdetsch commented Apr 9, 2020 

path <- system.file("extdata", package = "satellite")
files <- list.files(path, pattern = glob2rx("LC08*.TIF"), full.names = TRUE)
sat <- satellite(files)
sat_atmos <- calcAtmosCorr(sat, model = "DOS4", esun_method = "RadRef")

returns empty layers due to lns. 213-215 in satellite/calcAtmosCorr.R. Seems like DOS4 as suggested by Moran et al. (1992) has never been implemented, which makes the documentation in ?calcAtmosCorr rather misleading.

@tnauss, do you guys have free capacities to implement this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnauss tnauss

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnauss @fdetsch