envkey does not update secrets in unicorn when reloaded with USR2

[sethpollack]

Basically the first time unicorn boots, envkey loads the env vars but does not keep track of which keys it set. Then on subsequent reloads with USR2 it fails to update the values because they are now already set and envkey will not override them.

[danenania]

Looking into this--we probably need to handle unicorn reloads in the same way as spring reloads.

[sethpollack]

Yeah, or expose a hook that users can invoke in after_fork in unicorn.rb, resque.rb etc...

[danenania]

Hmm, actually you should already be able to do that by requiring envkey/core and calling Envkey::Core.load_env yourself. It returns two arrays, the keys set via dotenv and via envkey, so that it knows to override just the envkey ones on subsequent loads. I think this should work in unicorn.rb:

require "envkey/core"

ts = Time.now
overload_dotenv_vars, overload_envkey_vars = Envkey::Core.load_env
after_fork do
   Envkey::Core.load_env(ts, (overload_dotenv_vars || []), (overload_envkey_vars || []))
end

This interface can be cleaned up a bit and documented, but does that work for you in the meantime?

[sethpollack]

I'll give it a try thanks!

[sethpollack]

Doesn't seem to work, probably because the Railtie already ran?

[danenania]

Ah yes, in your Gemfile try adding require: false:

gem 'envkey', require: false

That should prevent the Railtie from running.

[sethpollack]

This doesn't work for me, the unicorn file gets loaded every time and resets overload_dotenv_vars and overload_envkey_vars.

[sethpollack]

What about doing something like this in Envkey::Core?

def self.envkey_original_env
    ENV["ENVKEY_ORIGINAL_ENV"] ||= ENV.to_json
    JSON.parse(ENV["ENVKEY_ORIGINAL_ENV"]).to_h
end

[danenania]

Yeah something along those lines should work--will get it pushed up soon!

[sethpollack]

Cool, thanks!

[danenania]

Should now be fixed in 1.2.6!

[sethpollack]

Thanks!