Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot load from home directory using envkey/envkeygo/v2 #27

Closed
tegaralaga opened this issue Sep 23, 2022 · 7 comments
Closed

cannot load from home directory using envkey/envkeygo/v2 #27

tegaralaga opened this issue Sep 23, 2022 · 7 comments

Comments

@tegaralaga
Copy link

tegaralaga commented Sep 23, 2022

guys, when I am using envkey/envkeygo/v2, I cannot load the ENVKEY from the home directory env file, even though it is stated that it will look into the home directory https://github.com/envkey/envkeygo/blob/647a3a294c40bea14988a6bf1849829197baf38d/loader/loader.go#L22

it is set to "envFileOverride"
https://github.com/envkey/envkeygo/blob/647a3a294c40bea14988a6bf1849829197baf38d/loader/loader.go#L25

These conditions will never be met

if envkey == "" && envFileOverride == "" {

or I am wrong in reading the code?

I am sorry for the broken English

@danenania
Copy link
Contributor

This is related to #26--a fix will be out shortly!

@danenania
Copy link
Contributor

danenania commented Sep 23, 2022

Should now be fixed in envkey-source 2.0.27 and envkeygo 2.0.10

@tegaralaga
Copy link
Author

Hi @danenania I don't see it is fixed.

from https://github.com/envkey/envkeygo/blob/master/loader/loader.go#L25 still using "envFileOverride" as an override.
the condition in https://github.com/envkey/envkey/blob/sdkgo-v2.0.10/public/sdks/envkey-source/env/env.go#L75 will never met.

@danenania
Copy link
Contributor

I see--missed that there was also a problem in envkeygo. A fix will be out shortly.

@danenania
Copy link
Contributor

@tegaralaga should now be fixed in envkeygo 2.0.11

@sasimovva
Copy link

@danenania - We are still having this issue with envkeygo on 2.3.0..

@danenania
Copy link
Contributor

Hi @sasimovva could you give a bit more detail? envkeygo isn't loading a ~/.env file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants