Swift PM and Linux Support #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangpenlin
reviewed
Jul 5, 2018
Package.resolved
Outdated
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
@cpageler93 I guess maybe we don't want to include package.resolved in this package. The document says it seems like having Package.resolved as a dependent has no effect to package which depends on it
but still it's kinda odd to ping the version here as this is a lib package, it makes no sense to pin the version of embassy here
fangpenlin
reviewed
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to participate in this project by adding support for Swift Package Manager and some fixes for Linux os.
Please let me know when i missed something.
Thanks