Port to Android #99
Closed
Port to Android #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also gets the tests running on linux again.
finagolfin
commented
Jun 30, 2022
| @@ -96,7 +102,7 @@ func makeRandomString(_ length: Int) -> String { | |||
| let endIndex = UInt32(letters.count - 1) | |||
| let result: [Any?] = Array(repeating: nil, count: length) | |||
| return String(result.map({ _ in | |||
| letters[String.Index(encodedOffset: Int(arc4random_uniform(endIndex)))] | |||
| letters[String.Index(encodedOffset: Int(randomUniform(endIndex)))] | |||
There was a problem hiding this comment.
This was changed in b21f401 and broke on linux.
|
Pinging @Goos, what do you think? |
|
@gregjlee, still involved? |
|
@beckychristensen, I notice you got another pull in recently, mind looking at this one? |
|
Ping @Goos, still looking to get this in. |
|
Ping @Goos, I see a few other pulls have been merged since I opened this, any reason I've gotten no response on this? |
|
Closing since a year has gone by with no response from the code owners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also gets the tests running on linux again.
I used an earlier version of this pull when packaging CookCLI for Android last weekend, termux/termux-packages#11081. I tested this pull by running
swift teston Ubuntu 20.04 x86_64 and Android 12 AArch64 without a problem.