Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support level trigger user space event and resolve fails_on_windows introduced in #13418 #13865

Open
lambdai opened this issue Nov 2, 2020 · 5 comments
Assignees
Labels

Comments

@lambdai
Copy link
Contributor

lambdai commented Nov 2, 2020

@lambdai if you leave fails_on_windows tests do you mind opening an issue and tagging it as windows only with some context on the feature that we need to implement. We do this because it is easier to track than fails_on_windows tags.

@davinci26
Absolutely. I will add immediately after the PR is merged.

Originally posted by @lambdai in #13418 (comment)

@sunjayBhatia
Copy link
Member

@lambdai could you add some more detail about why the test is marked as failing and how the test fails? (error output, failed expectations, etc.)

@lambdai
Copy link
Contributor Author

lambdai commented Nov 3, 2020

@sunjayBhatia I can add more details or fixed it when the PR is landed.

Basically I am creating a user space event implementation. And the implementation in that PR only support edge trigger.

It's an ASSERT failure "level trigger type" is passed in.

My entire PR is an extension so it's completely safe if you don't enable it.

@davinci26
Copy link
Member

I think I can get this "for free" with #13787 feel free to assign this to me

@sunjayBhatia
Copy link
Member

/assign davinci26

@davinci26 davinci26 self-assigned this Nov 3, 2020
@wrowe
Copy link
Contributor

wrowe commented May 7, 2021

Ping @davinci26 and @lambdai for status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants