Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why don't allow updates to statically configured clusters via addOrUpdateCluster function? #14437

Open
wangfakang opened this issue Dec 16, 2020 · 3 comments
Open

Why don't allow updates to statically configured clusters via addOrUpdateCluster function? #14437

wangfakang opened this issue Dec 16, 2020 · 3 comments
Labels
area/configuration area/docs help wanted Needs help!

Comments

@wangfakang
Copy link
Member

Why don't allow updates to statically configured clusters via ClusterManagerImpl::addOrUpdateCluster at the runtime?
@wangfakang wangfakang added the triage Issue requires triage label Dec 16, 2020
@alyssawilk alyssawilk added question Questions that are neither investigations, bugs, nor enhancements area/configuration and removed triage Issue requires triage labels Dec 16, 2020
@alyssawilk
Copy link
Contributor

cc @htuch @mattklein123 might make a good FAQ entry - I was tripped up by this one myself once

@mattklein123
Copy link
Member

OK I can do this. The reason is basically that it would be very confusing if static clusters get removed by CDS, and also some code is not built for CDS delivered clusters and might crash if a static cluster gets removed. Updates would probably be OK it's just not implemented.

@mattklein123 mattklein123 added area/docs help wanted Needs help! and removed question Questions that are neither investigations, bugs, nor enhancements labels Dec 17, 2020
@mattklein123 mattklein123 self-assigned this Dec 17, 2020
@ramaraochavali
Copy link
Contributor

Curious, what kind of updates are you thinking for a static cluster?

@mattklein123 mattklein123 removed their assignment Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/configuration area/docs help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattklein123 @wangfakang @ramaraochavali @alyssawilk