Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] renovatebot for bazel deps #15955

Open
asraa opened this issue Apr 13, 2021 · 3 comments
Open

[deps] renovatebot for bazel deps #15955

asraa opened this issue Apr 13, 2021 · 3 comments
Labels
dependencies Pull requests that update a dependency file enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@asraa
Copy link
Contributor

asraa commented Apr 13, 2021

Title: renovatebot for bazel deps

Description:
I recently came across this project https://github.com/renovatebot/renovate that states it has support for updating http_archives and other bazel deps. I'm curious if anyone has heard or tried it, and has any opinions on whether it might work.

I worry that

  • It will not handle our repository_locations.bzl and our metadata format
  • It will have too much noise or sense of priority, and will not be helpful in case dependency updates require changes and fixes in the repo

Ideally, it seems like we want a tool on top of it that can handle priority and being compliant with formatting. There are already warnings on new releases that appear in CI logs. (Another improvement would be making those warnings more visible)

@asraa asraa added enhancement Feature requests. Not bugs or questions. dependencies Pull requests that update a dependency file labels Apr 13, 2021
@phlax
Copy link
Member

phlax commented Apr 13, 2021

looks good! i checked previously for dependabot <> bazel but it doesnt currently have support

...in case dependency updates require changes and fixes

afaict it creates PRs, so at very least, if we can make it work, its an independent warning system about dep updates (and possibly sec issues)

@moderation
Copy link
Contributor

moderation commented Apr 13, 2021

I came across this as well @asraa and pinged @htuch about it on Slack. I haven't gotten around to installing the self-hosted version. It looks like it might work - https://docs.renovatebot.com/modules/manager/bazel/

We currently have a lot of out of date deps as reported by tools/dependency/release_dates.py. We'll need to see if it works and whether it provides more value than the Python script we have traded off against it's complexity, size, maintenance etc.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 13, 2021
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

3 participants