Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs/containers for insecure releases #16034

Open
phlax opened this issue Apr 16, 2021 · 6 comments
Open

Remove docs/containers for insecure releases #16034

phlax opened this issue Apr 16, 2021 · 6 comments
Assignees
Labels
area/docker area/docs no stalebot Disables stalebot from closing an issue

Comments

@phlax
Copy link
Member

phlax commented Apr 16, 2021

description

checking the docs page, i think some of the docs relate to builds/releases for which there are known sec issues:

https://www.envoyproxy.io/docs

(also, some of the links are dead)

afaict there are also still dockerhub images with a similar issue:

https://hub.docker.com/r/envoyproxy/envoy/tags?page=1&ordering=last_updated&name=1.17

if you read the docs and look at the published images there is no way of knowing that some versions should be avoided

imho we should probably just delete all images and docs other than the latest for each minor version

@phlax phlax added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Apr 16, 2021
@phlax
Copy link
Member Author

phlax commented Apr 16, 2021

cc @mattklein123

@phlax phlax added area/docker area/docs and removed triage Issue requires triage enhancement Feature requests. Not bugs or questions. labels Apr 16, 2021
@mattklein123
Copy link
Member

I don't think we can remove old images, because for better or worse people may be pinned to them.

I think removing old releases is very reasonable. Do you want to do a PR over on the docs site? https://github.com/envoyproxy/envoyproxy.github.io/blob/c470b304486a3ca1edbc50527c1f5ea32e2db290/_config.yml#L25

@phlax
Copy link
Member Author

phlax commented Apr 16, 2021

sort of yes - the repo is huge - need to find some disk space to do it

after playing with netlify over on envoy-playground - i like it a lot - but i guess that is a separate issue

@phlax
Copy link
Member Author

phlax commented Apr 16, 2021

also just thinking we may need to change envoy ci too to prevent changes being overwritten (ill check further)

@phlax
Copy link
Member Author

phlax commented Apr 24, 2021

the other thing i need to proceed with this are:

  • supported versions
  • list of known insecure versions

@phlax phlax self-assigned this Apr 27, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 27, 2021
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker area/docs no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

2 participants