Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix field name: idle_timeout field name lost underscore #16070

Merged
merged 1 commit into from Apr 20, 2021
Merged

docs: fix field name: idle_timeout field name lost underscore #16070

merged 1 commit into from Apr 20, 2021

Conversation

addozhang
Copy link
Contributor

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message: fix underscore lost in field name idle_timeout
Additional Description: fix doc
Risk Level: N/A
Testing: N/A
Docs Changes: docs/root/faq/configuration/timeouts.rst
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

Hi @addozhang, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #16070 was opened by addozhang.

see: more, trace.

Signed-off-by: addozhang <duwasai@gmail.com>
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asraa asraa self-assigned this Apr 19, 2021
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snowp snowp merged commit a809844 into envoyproxy:main Apr 20, 2021
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
…6070)

Signed-off-by: addozhang <duwasai@gmail.com>
Signed-off-by: Gokul Nair <gnair@twitter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants