Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move protodoc to envoy_py_binary and use a single jinja template to render #16328

Open
phlax opened this issue May 5, 2021 · 2 comments
Open

Move protodoc to envoy_py_binary and use a single jinja template to render #16328

phlax opened this issue May 5, 2021 · 2 comments
Assignees
@phlax
Labels
area/docs area/protobuf area/python code help wanted Needs help!

Comments

@phlax
Copy link
Member

phlax commented May 5, 2021

description

protodoc will benefit quite a lot from moving to the newer envoy_py_binary format and moving tests to pytest

what would also greatly simplify the code is using the existing visitor pattern to collect up a py dictionary of the page structure and injecting that to a single template, rather than lots of snippets and \n workarounds
@phlax phlax added the triage Issue requires triage label May 5, 2021
@phlax
Copy link
Member Author

phlax commented May 5, 2021

cc @htuch

@phlax phlax added area/docs area/protobuf area/python code help wanted Needs help! and removed triage Issue requires triage labels May 5, 2021
@phlax phlax self-assigned this May 5, 2021
@phlax phlax mentioned this issue May 5, 2021
Open
@htuch
Copy link
Member

htuch commented May 6, 2021

Sure, these are all good directions to take protodoc; the tools has likely reached the point that Jinja templates would be a reasonable improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phlax phlax

Labels
area/docs area/protobuf area/python code help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phlax @htuch