Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple health checkers per cluster #16391

Closed
wbpcode opened this issue May 8, 2021 · 7 comments
Closed

support multiple health checkers per cluster #16391

wbpcode opened this issue May 8, 2021 · 7 comments
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@wbpcode
Copy link
Member

wbpcode commented May 8, 2021

Title: support multiple health checkers per cluster

Description:
This is a very old issue. I happened to be doing some related work recently, so I am trying to see if I can close this issue. Here is some simple design.

[optional Relevant Links:]

#3642

we are running into this same issue, it appears both api v2 and api v3 accept multiple health checks, but envoy itself does not support them

@wbpcode wbpcode added the triage Issue requires triage label May 8, 2021
@wbpcode
Copy link
Member Author

wbpcode commented May 8, 2021

API: The Health Checkers for the Upstream Cluster currently provided by the community is an array that can accept multiple Health Checkers, so the API can be reused directly without redesign. In the initial design, if any Health Checker fails, the Host is marked as unhealthy. Multiple Health Checkers work independently of each other and are identified with a unique ID.

Record: An additional Flag will be used to record which Health Checker has set the status of the Host. For example, each bit represents a Health Checker.

Status Update:

  • If Health Checker X considers the status of Host A to be healthy:
    • If the previous status of A is healthy: Do nothing.
    • If the previous status of A is unhealthy: Clear Flag set by X. If Flag == 0, then update status of A to be healthy.
  • If Health Checker X considers the status of Host A to be unhealthy:
    • If the previous status of A is healthy: Set Flag and update status of A to be unhealthy.
    • If the previous status of A is unhealthy: Set Flag.

@antoniovicente antoniovicente added enhancement Feature requests. Not bugs or questions. and removed triage Issue requires triage labels May 10, 2021
@antoniovicente
Copy link
Contributor

Is this a duplicate of #3642 ?

@wbpcode
Copy link
Member Author

wbpcode commented May 11, 2021

Is this a duplicate of #3642 ?

This is a reply to #3642 and I will create a PR that used to close #3642.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 10, 2021
@wbpcode
Copy link
Member Author

wbpcode commented Jun 17, 2021

/no-stale

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 17, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 17, 2021
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants