Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load balancing for multiple IPs of a FQDN in dynmic fwding proxy #16426

Open
Sooryaa-A opened this issue May 11, 2021 · 10 comments
Open

Load balancing for multiple IPs of a FQDN in dynmic fwding proxy #16426

Sooryaa-A opened this issue May 11, 2021 · 10 comments
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@Sooryaa-A
Copy link

Sooryaa-A commented May 11, 2021

Title: Supporting load balancing for mulitple IPs of a FQDN in dynamic fwd proxy, Similar to strict DNS

Description:
Currently dynamic fwd proxy , dns resolution works similar to LOGICAL DNS, where the very first IP resolved from IP list of an FQDN is getting cached and used for communication.
In a load run case, its like though there are many end points available for a single FQDN, only the same IP will get used, which is not correct.
in our case the number of originators are 1-2 pods, but the serving end has more end points. If two originators are there means only two IP can get used .

[optional Relevant Links:]
I have raised a query regarding this n slack , but didnt get any clarification.
https://envoyproxy.slack.com/archives/C78HA81DH/p1620188772051000?thread_ts=1611234659.004800&cid=C78HA81DH

@Sooryaa-A Sooryaa-A added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels May 11, 2021
@antoniovicente antoniovicente removed the triage Issue requires triage label May 11, 2021
@antoniovicente
Copy link
Contributor

cc @alyssawilk

It does sound like an useful enhancement.

@alyssawilk
Copy link
Contributor

Yeah right now this is a tricky feature because the upstream host only gets one dns result.
@DavidSchinazi will be landing improvements to DFP soon, to handle multiple addresses serially (for happy eyeballs) and it while I don't think we'll have the cycles to work on doing multiple in parallel, we'll at least do loads of refactoring work to make that work easier. If anyone's up for springboarding off those changes to work on parallel connections we'd be happy to help brainstorm design and do reviews.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 10, 2021
@Sooryaa-A
Copy link
Author

any update on this?

@Sooryaa-A
Copy link
Author

Yeah right now this is a tricky feature because the upstream host only gets one dns result.
@DavidSchinazi will be landing improvements to DFP soon, to handle multiple addresses serially (for happy eyeballs) and it while I don't think we'll have the cycles to work on doing multiple in parallel, we'll at least do loads of refactoring work to make that work easier. If anyone's up for springboarding off those changes to work on parallel connections we'd be happy to help brainstorm design and do reviews.

any brainstorm happening, on how this can be achieved?

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 14, 2021
@alyssawilk
Copy link
Contributor

I think it's a reasonable feature but someone would have to sign on to do the work :-)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 14, 2021
@DavidSchinazi
Copy link
Contributor

@alyssawilk can you please add the "no stalebot" label to this issue? I think we'll want to keep this issue alive even if we won't address it very soon

@DavidSchinazi
Copy link
Contributor

@Sooryaa-A can you clarify something please? Are you saying you would like DFP to send requests between DNS results round robin, or you saying that you would like to make sure we try multiple DNS results until we find one that works? Thanks!

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 20, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 19, 2021
@alyssawilk alyssawilk added the no stalebot Disables stalebot from closing an issue label Aug 19, 2021
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

4 participants