Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplemented grpc response missing description #22688

Open
pixil98 opened this issue Aug 12, 2022 · 1 comment
Open

Unimplemented grpc response missing description #22688

pixil98 opened this issue Aug 12, 2022 · 1 comment
Labels
area/router enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@pixil98
Copy link

pixil98 commented Aug 12, 2022

Title: Unimplemented grpc response missing description

Description:

When Envoy receives a grpc requests for which is has no route, it responds with Unimplemented (12) and an empty description. It would be very helpful to debugging if it provided a description along the lines of "No route available".

Repro steps:

I reproduced this by running the official docker image for both 1.21-latest and 1.22-latest using the config below. I then used grpcui to send a request to the docker image for an rpc it didn't have a route for.

Config:

admin:
  address:
    socket_address: { address: 0.0.0.0, port_value: 9901 }

static_resources:
  listeners:
  - name: listener
    address:
      socket_address: { address: 0.0.0.0, port_value: 10000 }
    filter_chains:
    - filters:
      - name: envoy.filters.network.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
          stat_prefix: http
          codec_type: AUTO
          route_config: {}
          http_filters:
          - name: envoy.filters.http.router
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
@pixil98 pixil98 added bug triage Issue requires triage labels Aug 12, 2022
@wbpcode wbpcode added area/router help wanted Needs help! and removed triage Issue requires triage labels Aug 15, 2022
@wbpcode
Copy link
Member

wbpcode commented Aug 15, 2022

Sounds reasonable to me to add some more detailed description for this scene.
But I am not sure should we make the route_not_found awareable to the gRPC clients?

@wbpcode wbpcode added enhancement Feature requests. Not bugs or questions. and removed bug labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/router enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants