Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer sending in QuicConnection can't be enabled on Windows #22976

Open
danzh2010 opened this issue Sep 2, 2022 · 0 comments
Open

Defer sending in QuicConnection can't be enabled on Windows #22976

danzh2010 opened this issue Sep 2, 2022 · 0 comments

Comments

@danzh2010
Copy link
Contributor

#22796 enables QuicConnection defer sending on other platforms. This is an optimization to improve CPU cost in light of UDP GSO. But this QUICHE behavior change causes test failures on Windows, i.e.

Protocols/FilterIntegrationTest.H3PostHandshakeFailoverToTcp/IPv4_Http2Downstream_Http3UpstreamNghttp2NoDeferredProcessing
.\test/integration/server.h(484): error: Value of: TestUtility::waitForCounterEq(statStore(), name, value, time_system_, timeout, dispatcher)
  Actual: false (timed out waiting for cluster.cluster_0.upstream_cx_destroy to be 2, current value 1)
Expected: true
Stack trace:
  00007FF6ACD850CC: (unknown)
  00007FF6ACD84FB6: (unknown)
  00007FF6ACD9E258: (unknown)
  00007FF6ACD9E41D: (unknown)
  00007FF6ACD9EE8D: (unknown)
... Google Test internal frames ...

[2022-08-26 22:17:36.929][4684][critical][assert] [test/integration/http_integration.cc:527] assert failure: 0. Details: Timed out waiting for new connection.

And we never verified it can also improve CPU performance on Windows, given that Windows doesn't support GSO.

We should sort out those test failures and verify the improvement on Windows platform.

@danzh2010 danzh2010 added bug triage Issue requires triage labels Sep 2, 2022
@mattklein123 mattklein123 added help wanted Needs help! area/quic area/windows and removed bug triage Issue requires triage labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants