Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing distinct oauth filter logging option #23306

Closed
DanApostol opened this issue Sep 29, 2022 · 4 comments
Closed

Missing distinct oauth filter logging option #23306

DanApostol opened this issue Sep 29, 2022 · 4 comments
Labels
area/oauth enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@DanApostol
Copy link

Cannot configure logging level for Oauth filter

When starting the envoy using --component-log-level option, you cannot set a distinct value for oauth filter.

Two fixes needed:

  • add oauth value in Enum in logger.h in the list
    #define ALL_LOGGER_IDS(FUNCTION)

  • configure new value (oauth instead upstream) in oauth_client.h in the line:
    class OAuth2ClientImpl : public OAuth2Client, Logger::LoggableLogger::Id::upstream {

Sources were inspected on main branch.

Thank you in advance.
Dan.

@DanApostol DanApostol added bug triage Issue requires triage labels Sep 29, 2022
@yanavlasov yanavlasov added enhancement Feature requests. Not bugs or questions. help wanted Needs help! area/oauth and removed bug triage Issue requires triage labels Sep 29, 2022
@StarryVae
Copy link
Contributor

So, is it resonable to fix this, and is any one working on it? if no, i will try to fix.

@kanurag94
Copy link
Contributor

I think this is done, should we close this issue? @StarryVae @DanApostol

@StarryVae
Copy link
Contributor

yeah, i think we can close it.

@DanApostol
Copy link
Author

Ok, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oauth enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

4 participants