-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont run (mobile) github actions (for required checks) if there is no need #24437
Comments
i was going to comment something similar on the PR but it landed before i had gotten round to reviewing it |
Oh nice, I wasn't aware that this was possible. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
In #24407 a change was made to not use the
paths
feature in github actions to exclude checksthis was done to ensure that the checks could be
required
for PRs to passthe problem with this approach is that it pulls a full copy of the repo and is much slower than using githubs paths (which afaict uses its own diff algorithm against the target branch, and perhaps pre-checksout the repo - not sure about this exactly)
in more recent version of the github
actions/checkout
action the default is to pull the repo with adepth
of 1, so the currentmobile/should_run_ci.sh
script, where it assumes that the full repo is checked out, breaks (this is easy enough to workaround but just hightlights the issue)i think we can speed this up and reduce the load on CI considerably by reverting to using the
paths
selector and adding the github way of allowing a required check to pass when skipped (https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks)like the azp way its a bit kludgy but it think it would be quite a bit faster/more efficient
The text was updated successfully, but these errors were encountered: