Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formally deprecate *_METADATA access log command operators #33004

Open
jbohanon opened this issue Mar 20, 2024 · 5 comments
Open

Formally deprecate *_METADATA access log command operators #33004

jbohanon opened this issue Mar 20, 2024 · 5 comments
Assignees
Labels
area/access_log enhancement Feature requests. Not bugs or questions. help wanted Needs help! stale stalebot believes this issue/PR has not been touched recently

Comments

@jbohanon
Copy link
Contributor

Title: Formally deprecate *_METADATA access log command operators

Description:
The documentation for the command operators for access log formatting DYNAMIC_METADATA and CLUSTER_METADATA has indicated that these will be deprecated in favor of the METADATA formatter since the latter was implemented. We should actually deprecate these and make plans for their removal.

Relevant Links:
https://github.com/envoyproxy/envoy/pull/17457/files#diff-a5eb61dd3a95c605846ebaba934b7334bc18f96fbf9ebf7593a90948c92f19c5

@cpakulski
Copy link
Contributor

Correct, this has been on my plate for a while, so I can drive deprecation. METADATA is right now an extension and I believe that in order to deprecate *_METADATA, the generic formatted must be moved out of extensions to core formatters.

@cpakulski cpakulski self-assigned this Mar 20, 2024
@htuch htuch added enhancement Feature requests. Not bugs or questions. area/access_log and removed triage Issue requires triage labels Mar 21, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 20, 2024
@jbohanon
Copy link
Contributor Author

@cpakulski is this actively in progress or should we tag it help-wanted

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 20, 2024
@cpakulski
Copy link
Contributor

@jbohanon Thanks for reminding. It will be done for the next release.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 22, 2024
@cpakulski cpakulski added the help wanted Needs help! label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access_log enhancement Feature requests. Not bugs or questions. help wanted Needs help! stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants