Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source/common/stats coverage is flaky #33415

Closed
RyanTheOptimist opened this issue Apr 9, 2024 · 4 comments
Closed

source/common/stats coverage is flaky #33415

RyanTheOptimist opened this issue Apr 9, 2024 · 4 comments

Comments

@RyanTheOptimist
Copy link
Contributor

Post-submit source/common/stats coverage is flaky:
PASS: https://storage.googleapis.com/envoy-postsubmit/c8f3466/coverage/source/common/stats/index.html
FAIL: https://storage.googleapis.com/envoy-postsubmit/0811e14/coverage/source/common/stats/index.html

The difference appears to be lack of coverage of line 290 in coverage/source/common/stats/tag_extractor_impl.cc, an early return in TagExtractorTokensImpl::searchTags().

PASS: https://storage.googleapis.com/envoy-postsubmit/c8f3466/coverage/source/common/stats/tag_extractor_impl.cc.gcov.html
FAIL: https://storage.googleapis.com/envoy-postsubmit/0811e14/coverage/source/common/stats/tag_extractor_impl.cc.gcov.html

@RyanTheOptimist
Copy link
Contributor Author

@jmarantz is this something we could write a simple unit test for to avoid the flake?

@jmarantz
Copy link
Contributor

jmarantz commented Apr 9, 2024

did this start with #33191 ?

@alyssawilk

@phlax
Copy link
Member

phlax commented Apr 9, 2024

i think this was fixed here #33411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants