Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC HTTP/1.1 bridge could map gRPC codes to HTTP response codes #33664

Closed
dmateusp opened this issue Apr 18, 2024 · 4 comments
Closed

gRPC HTTP/1.1 bridge could map gRPC codes to HTTP response codes #33664

dmateusp opened this issue Apr 18, 2024 · 4 comments
Labels
area/grpc area/http_filter enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@dmateusp
Copy link

gRPC HTTP/1.1 bridge could map gRPC codes to HTTP response codes:

Currently the gRPC HTTP/1.1 bridge sets the HTTP response code to 503 for any non-0 gRPC codes, it would be great to use a sensible mapping to HTTP response codes instead.

Description:

The mapping in the bridge could be changed to set the HTTP response code based on the mapping you can find in the comments of googleapis/google/rpc/code.proto instead of using 503. In our case it would be useful to return these codes for monitoring / logging on our GCP load balancer.

Relevant Links

See gRPC HTTP bridge docs "the filter switches the HTTP response code to 503"

@dmateusp dmateusp added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Apr 18, 2024
@adisuissa adisuissa added area/grpc area/http_filter and removed triage Issue requires triage labels Apr 19, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 19, 2024
@derekargueta
Copy link
Member

I think this would be a good idea

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label May 20, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 19, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc area/http_filter enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants