Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sending response body, headers, and status code to client on Extauthz filter CheckStatus::Error #34005

Closed
mikehuston opened this issue May 7, 2024 · 3 comments
Labels
area/ext_authz enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@mikehuston
Copy link

mikehuston commented May 7, 2024

Title: Support for sending response body, headers, and status code to client on Extauthz filter CheckStatus::Error

Description:
Allow both http and grpc extauthz filters to support sending response headers and status code from the extauthz service to the client on extauthz 5xx response. I'm looking for #24845, for both HTTP and gRPC extauthz filter impls.

What scenarios it enables:

  • [Response headers] When our extauthz service returns 5xx, it'd be extremely useful for downtime debugging and error attribution to pass internal metadata about the errored request (such as token type used, customer identifier, high level error category) to our Envoy access logs (we will remove these internal headers before sending the response to the client).
  • [Status code] clients can distinguish between 500 (internal error, don't retry) and 503 (temporarily unavailable, retry)
  • [Body] a custom response body that contains a unique request identifier and/or error message will help customers and us determine next steps of action for errored requests.
  • [Response headers] It will allow us to send headers to the client such as Retry-After for 503

Relevant Links:
#24845

@mikehuston mikehuston added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels May 7, 2024
@phlax phlax added area/ext_authz and removed triage Issue requires triage labels May 8, 2024
@phlax
Copy link
Member

phlax commented May 8, 2024

cc @agrawroh @esmet @tyxia @ggreenway

Copy link

github-actions bot commented Jun 7, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 7, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ext_authz enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants