-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing max_request_headers_kb
in HCM not working properly
#34231
Comments
max_request_headers_kb
in HCM not workingmax_request_headers_kb
in HCM not working properly
TEST_P(DownstreamProtocolIntegrationTest, ManyLargeRequestHeadersAccepted) { has been testing the max headers logic continuously for ages so I think max_request_headers_kb is probably working as advertised. can you turn up info logging and let me know what "Sending local reply" message you see? |
Thanks for the comments @ravenblackx and @alyssawilk, here are more detailed steps to reproduce it. The header field i used is 16KB and
Versionenvoy 1.30.1 Config
Start Envoy
Make request
Logs
|
So I'm not running the same upstream as you - seems to route happily to google.com (which sends back a 404) |
@alyssawilk aha, it turns out it's the issue from our upstream service which has smaller max http header size, so we need to make sure the allowed max http header size of our upstream service >= envoy configured one. Thanks! |
Title: Increasing
max_request_headers_kb
in HCM not workingDescription:
I got
431 Request Header Fields Too Large
from envoy as we are adding some larger request header within wasm filter (size might slight over 60KiB), by doing some researching, the default value is60KiB
and we could increase themax_request_headers_kb
based on the doc here but seems like it's not working properly.here is the partial of the HCM config:
our envoy version: 1.30
i'm sure my envoy config is correct and other fields in the HCM config works properly, only the max_request_headers_kb doesn't have any effect, I have tried to increase
max_request_headers_kb
to even few hundreds or thousands which is enough size, as this field max value has been increased to 8MiB since 1.19, refBut envoy still gives me
431 Request Header Fields Too Large
, this config didn't seem to increase themax_request_headers_kb
properly.Also i have also tried to increase
common_http_protocol_options.max_headers_count
to ensure the 431 is not causing by the headers count overflow, but it doesn't help either as I'm quite sure the problem was causing from one header field was larger than 60KiB (if not set that large request header, everything is fine)Any ideas would be appreciated, thank yoU!
The text was updated successfully, but these errors were encountered: