Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Configuration for Minimum Healthy Upstream Nodes in Health Checking #34407

Closed
Melod-YI opened this issue May 29, 2024 · 2 comments
Closed
Labels
area/health_checking enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@Melod-YI
Copy link

Melod-YI commented May 29, 2024

I've noticed that in Envoy's health check configuration for upstream nodes, has no option to set a minimum number of healthy nodes. Like max_ejection_percent in outlier detection.

Since both health checking and outlier detection are mechanisms to identify and ejection unhealthy upstream nodes, I'd expect the health checking configuration to also provide options like "minimum healthy nodes" or "maximum unhealthy nodes" to control the behavior when the number of healthy nodes falls below or exceeds certain thresholds.

I'm wondering if there's a specific reason why such configurations are not available in Envoy's health checking, or if there are any plans to introduce them in the future. If there's a better way to achieve similar functionality, I'd appreciate any guidance or recommendations.

@Melod-YI Melod-YI added the triage Issue requires triage label May 29, 2024
@Melod-YI Melod-YI changed the title Lack of Configuration for Minimum/Maximum Healthy Upstream Nodes in Health Checking Lack of Configuration for Minimum Healthy Upstream Nodes in Health Checking May 29, 2024
@jmarantz jmarantz added enhancement Feature requests. Not bugs or questions. area/health_checking and removed triage Issue requires triage labels May 31, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 1, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/health_checking enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants