Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to skip stat-name truncation for not-hot-restart case #3965

Closed
jmarantz opened this issue Jul 27, 2018 · 2 comments
Closed

Add capability to skip stat-name truncation for not-hot-restart case #3965

jmarantz opened this issue Jul 27, 2018 · 2 comments
Assignees
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@jmarantz
Copy link
Contributor

Description:

Limited stat-name sizes are needed in the hot-restart case to allow friendlier allocation in fixed-size shared-memory block. They probably just get in the way for the non-hot-restart case. Note that when heap-stats are used as overflow for shared-mem stats, they should be truncated the same way.

@ambuc
Copy link
Contributor

ambuc commented Jul 27, 2018

@htuch You can assign this to me.

@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Jul 27, 2018
@ambuc
Copy link
Contributor

ambuc commented Aug 9, 2018

@jmarantz @htuch Let's close this issue as unwanted -- as-is, heap-allocated stats don't truncate. This issue would require us to flip that behavior yet again, truncate heap-allocated stats by default, and then require a CLI flag to not truncate stat names.

@htuch htuch closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

4 participants