Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control on xDS deduplication based on protobuf #8301

Open
lizan opened this issue Sep 19, 2019 · 1 comment
Open

Better control on xDS deduplication based on protobuf #8301

lizan opened this issue Sep 19, 2019 · 1 comment
Labels
api/v3 Major version release @ end of Q3 2019 design proposal Needs design doc/proposal before implementation help wanted Needs help!

Comments

@lizan
Copy link
Member

lizan commented Sep 19, 2019

From discussion in #8231 (comment)

Key take aways:

  • Prefer using version_info instead comparing new xDS delivered config with existing one, this also solves SDS onConfigUpdate ignores resource version #7676

  • Add a UUID in ConfigSource for deduplication, instead of hashing ConfigSource proto to automatically dedup. This means RDS/SDS ConfigSource sent from LDS should be deduplicated at control plane.

@lizan lizan added design proposal Needs design doc/proposal before implementation help wanted Needs help! labels Sep 19, 2019
@mattklein123 mattklein123 added the api/v3 Major version release @ end of Q3 2019 label Sep 19, 2019
@mattklein123
Copy link
Member

Add a UUID in ConfigSource for deduplication, instead of hashing ConfigSource proto to automatically dedup. This means RDS/SDS ConfigSource sent from LDS should be deduplicated at control plane.

For discussion, what I said is slightly different, which is to make sure that every resource has a name to use for hashing and lookup, and then use the message differencer Envoy side to look for changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v3 Major version release @ end of Q3 2019 design proposal Needs design doc/proposal before implementation help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants