Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GH workflow for egctl #1045

Closed
5 tasks done
Xunzhuo opened this issue Feb 15, 2023 · 3 comments · Fixed by #1249
Closed
5 tasks done

Add GH workflow for egctl #1045

Xunzhuo opened this issue Feb 15, 2023 · 3 comments · Fixed by #1249
Assignees
@Xunzhuo
Labels
area/ci CI and build related issues area/installation kind/enhancement New feature or request
Milestone
0.4.0-rc.1

Comments

@Xunzhuo
Copy link
Member

Xunzhuo commented Feb 15, 2023 •
edited
Loading

Description:

We should add egctl to build and test workflow, and release/(latest-release) workflow.

Subtasks:
@Xunzhuo Xunzhuo added kind/enhancement New feature or request area/ci CI and build related issues area/installation labels Feb 15, 2023
@arkodg arkodg added this to the 0.4.0-rc.1 milestone Feb 15, 2023
@Xunzhuo Xunzhuo self-assigned this Feb 16, 2023
@Xunzhuo Xunzhuo mentioned this issue Feb 20, 2023
Merged
@Xunzhuo Xunzhuo mentioned this issue Feb 28, 2023
Merged
@AliceProxy
Copy link
Member

IMO default install to /usr/local/bin should be ok assuming it is easy and obvious although I also really like the idea of installing to the local directory and then allowing the user to move the binary to their chosen location.

@arkodg
Copy link
Contributor

arkodg commented Mar 28, 2023

hey @Xunzhuo can we get this into 0.4.0-rc1 ?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Mar 30, 2023

@arkodg sure :)

@Xunzhuo Xunzhuo mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xunzhuo Xunzhuo

Labels
area/ci CI and build related issues area/installation kind/enhancement New feature or request
Projects
None yet
Milestone
0.4.0-rc.1
Development

Successfully merging a pull request may close this issue.

feat: support egctl releases Xunzhuo/gateway
3 participants
@arkodg @AliceProxy @Xunzhuo