Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket options SO_SNDBUF and SO_RCVBUF support #2670

Open
modatwork opened this issue Feb 22, 2024 · 8 comments · May be fixed by #3724
Open

Socket options SO_SNDBUF and SO_RCVBUF support #2670

modatwork opened this issue Feb 22, 2024 · 8 comments · May be fixed by #3724
Assignees
Labels

Comments

@modatwork
Copy link

Description:

Envoy will handle massive connections when used as L4 proxy. Setting the SO_SNDBUF and SO_RCVBUF socket options helps to limit the memory usage on each connection. So it would be nice to have these options in the APIs.

[optional Relevant Links:]

For downstream, Envoy has a socket_options in the listener config, https://www.envoyproxy.io/docs/envoy/v1.29.0/api-v3/config/listener/v3/listener.proto#config-listener-v3-listener

For upstream, Envoy has a socket_options in the upstream_bind_config field of the cluster config, https://www.envoyproxy.io/docs/envoy/v1.29.0/api-v3/config/cluster/v3/cluster.proto#config-cluster-v3-cluster

@arkodg
Copy link
Contributor

arkodg commented Feb 22, 2024

relates to #2600

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Mar 24, 2024
@aoledk
Copy link
Contributor

aoledk commented Apr 26, 2024

How about adding socket options array to ClientTrafficPolicy and BackendTrafficPolicy, for setting socket options in xDS listener and xDS cluster, to limit kernel socket's memory consumption.

@github-actions github-actions bot removed the stale label Apr 26, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label May 26, 2024
@zirain
Copy link
Contributor

zirain commented May 26, 2024

@arkodg is this fixed?

@github-actions github-actions bot removed the stale label May 26, 2024
@aoledk
Copy link
Contributor

aoledk commented May 28, 2024

@arkodg is this fixed?

No, this feature's api is still not defined. If we should do, I can work on this.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jun 27, 2024
@aoledk
Copy link
Contributor

aoledk commented Jul 1, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants