Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger a reconcile when the Otel backendRefs / Service changes #3412

Closed
zirain opened this issue May 17, 2024 · 0 comments · Fixed by #3472
Closed

Trigger a reconcile when the Otel backendRefs / Service changes #3412

zirain opened this issue May 17, 2024 · 0 comments · Fixed by #3472
Assignees
@zirain
Labels
provider/kubernetes Issues related to the Kubernetes provider
Milestone
v1.1.0-rc1

Comments

@zirain
Copy link
Contributor

zirain commented May 17, 2024 

          we probably also need to enhance https://github.com/envoyproxy/gateway/blob/e5f86303d83d732f8c3890a6868c62e29a3e3029/internal/provider/kubernetes/predicates.go#L217 to make sure we trigger a reconcile when the `Service` changes

Originally posted by @arkodg in #3293 (comment)
@zirain zirain changed the title probably also need to enhance https://github.com/envoyproxy/gateway/blob/e5f86303d83d732f8c3890a6868c62e29a3e3029/internal/provider/kubernetes/predicates.go#L217 to make sure we trigger a reconcile when the Service changes probably also need to make sure we trigger a reconcile when the Service changes May 17, 2024
@arkodg arkodg changed the title probably also need to make sure we trigger a reconcile when the Service changes Trigger a reconcile when the Otel backendRefs / Service changes May 23, 2024
@arkodg arkodg added this to the v1.1.0-rc1 milestone May 23, 2024
@arkodg arkodg added the provider/kubernetes Issues related to the Kubernetes provider label May 23, 2024
@zirain zirain mentioned this issue May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zirain zirain

Labels
provider/kubernetes Issues related to the Kubernetes provider
Projects
None yet
Milestone
v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

Trigger a reconcile when EnvoyProxy backendRefs changes zirain/gateway
2 participants
@zirain @arkodg