Upgrade protoc-gen-go-grpc used for generating .pb.gos

[menghanl]

The .pb.gos are generated using old versions of codegen.

Some noticeable differences:

1. messages and services are in the same file, e.g. v3/csds.pb.go has messages and services
   • see helloworld where they are separated
2. The RegisterService() function still takes *grpc.Server, not grpc.ServiceRegistrar
   • see helloworld for the updated version

Where are versions of protoc-gen-go and protoc-gen-go-grpc configured?
Can we update to the newer versions? Thanks!

[menghanl]

@kyessenov Do you know where the script to generate pb.go files is kept?
If you point me to the script, I can make the changes. Thanks.

[kyessenov]

@menghanl sorry about the delay. The script is located in envoy repository https://github.com/envoyproxy/envoy/blob/main/tools/api/generate_go_protobuf.py. We probably need to bump bazel rules for golang to get newer plugins.

[menghanl]

It seems this cannot be done until rules_go adds support for the new code generators: bazelbuild/rules_go#2522

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

[phlax]

i reopened this and added nostale before realizing it wasnt in the envoy main repo - im guessing it probably does want to stay open tho

[alecholmez]

We need to revisit this before we cut a 1.0.

Maybe I can open some issues in the respective dependencies

[menghanl]

Why is this issue closed? Looking at the code, it doesn't seem to be fixed?
If it's fixed, can you link the PR? Thanks

[alecholmez]

@menghanl The issue was not fixed but the issue was stale and it requires upgrades it a few repos outside of go-control-plane. Envoy's repo would be a better place for this as well as rules_go