Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to detect wellknown types in nested messages #505

Merged
merged 6 commits into from Aug 16, 2021

Conversation

becoded
Copy link
Contributor

@becoded becoded commented Aug 11, 2021

Nested well-known types were not detected in nested messages:

message Foo {
  message Bar {
    string uuid = 1 [(validate.rules).string.uuid = true];
  }
}

would not add the required regex to the generated file as the UUID rule was not found.

Solving #462

@becoded becoded force-pushed the wellknown-in-nested-messages branch 3 times, most recently from 1e53076 to a26cea3 Compare August 11, 2021 22:23
@rodaine rodaine added Bug Reports and/or fixes a bug Enhancement Extend or improve functionality labels Aug 13, 2021
@rodaine
Copy link
Member

rodaine commented Aug 13, 2021

Great fix, thanks! Can we minimize the changes on this PR to those addressing the bug (so none of the Dockerfile/Makefile/go.mod diffs)? I'd be happy to approve those upgrades in a separate PR.

Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
@becoded becoded force-pushed the wellknown-in-nested-messages branch from d08144d to 06e51fe Compare August 16, 2021 06:10
@becoded
Copy link
Contributor Author

becoded commented Aug 16, 2021

@rodaine just pushed the changes so it only reflects addressing the bug!

@rodaine rodaine merged commit 338a2fb into bufbuild:main Aug 16, 2021
@rodaine
Copy link
Member

rodaine commented Aug 16, 2021

Thanks!

@becoded
Copy link
Contributor Author

becoded commented Aug 17, 2021

Thanks for the quick follow up!
Any chance of getting a tag bump now this is merged @rodaine?

@becoded becoded deleted the wellknown-in-nested-messages branch August 17, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reports and/or fixes a bug Enhancement Extend or improve functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants