New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to detect wellknown types in nested messages #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becoded
force-pushed
the
wellknown-in-nested-messages
branch
3 times, most recently
from
August 11, 2021 22:23
1e53076
to
a26cea3
Compare
rodaine
added
Bug
Reports and/or fixes a bug
Enhancement
Extend or improve functionality
labels
Aug 13, 2021
Great fix, thanks! Can we minimize the changes on this PR to those addressing the bug (so none of the Dockerfile/Makefile/go.mod diffs)? I'd be happy to approve those upgrades in a separate PR. |
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
Signed-off-by: Bert Van Hauwaert <bert@becoded.be>
becoded
force-pushed
the
wellknown-in-nested-messages
branch
from
August 16, 2021 06:10
d08144d
to
06e51fe
Compare
@rodaine just pushed the changes so it only reflects addressing the bug! |
rodaine
approved these changes
Aug 16, 2021
Thanks! |
Thanks for the quick follow up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested well-known types were not detected in nested messages:
would not add the required regex to the generated file as the UUID rule was not found.
Solving #462