Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy of #398: Add support for customization of validation error messages #546

Closed
wants to merge 35 commits into from
Closed

Copy of #398: Add support for customization of validation error messages #546

wants to merge 35 commits into from

Conversation

miparnisari
Copy link

@miparnisari miparnisari commented Dec 13, 2021 •
edited

This is #398 but with the latest changes merged.

DISCLAIMER: NOT TESTED MANUALLY

@codyaray
Add test assertions for error messages
8275a71 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
disable error message assertions for non-golang harness
021c9c9 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
Add support for i18n of validation error messages
fb05990 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
add more translation strings
4db3d35 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
fix build and cleanup i18n init code
e5aad8d 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
commas
aaf97f8 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
missing dep
a0f0dbc 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
missing deps
2d6c22e 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
typo template
d41b7fe 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
missing dep
2ec1384 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
touch to rerun CI
d224205 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
fix shasum
41f30d4 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
more deps
59be6f4 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
gorm? this is getting ridic
2b77dcf 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
let gazelle update some deps
025cd8c 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
fix gazelle cleanup
452f6aa 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
fix ltgt
90be090 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
try sprint
019c88c 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
test without translate lib
9db5eb3 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
comment out unused
f2eb072 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
fix the issue with html-escaped strings
c75bc4d 
Signed-off-by: Cody A. Ray <cody@confluent.io>
@codyaray
Merge branch 'master' into i18n
e676661
@miparnisari miparnisari mentioned this pull request Dec 13, 2021
Closed
@miparnisari
Run make gazelle
6d89409 
Signed-off-by: Maria Ines Parnisari <maineparnisari@gmail.com>
@miparnisari
fix typo
b22ead7 
Signed-off-by: Maria Ines Parnisari <maineparnisari@gmail.com>
@miparnisari
try to fix build
b7e9175 
Signed-off-by: Maria Ines Parnisari <maineparnisari@gmail.com>
@miparnisari miparnisari marked this pull request as draft December 15, 2021 02:13
@pdecks pdecks mentioned this pull request Dec 17, 2021
Closed
@miparnisari
try to fix build, attempt 3
8df6aeb 
Signed-off-by: Maria Ines Parnisari <maineparnisari@gmail.com>
@miparnisari
test fixes
de4f80b 
Signed-off-by: Maria Ines Parnisari <maineparnisari@gmail.com>
@miparnisari miparnisari marked this pull request as ready for review December 18, 2021 04:55
ghost
ghost previously approved these changes Dec 24, 2021
View reviewed changes
@miparnisari
Merge branch 'main' into i18n
332c5d3
@miparnisari
fix build error - undefined: wrapperspb
38c65e1 
Signed-off-by: Maria Ines Parnisari <maineparnisari@gmail.com>
@miparnisari miparnisari changed the title Copy of #398 Copy of #398: Add support for customization of validation error messages Feb 1, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Activity has stalled on this issue/pull-request label Apr 16, 2022
@miparnisari
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

noooo

@stale stale bot removed the Stale Activity has stalled on this issue/pull-request label Apr 18, 2022
@rmichela
Copy link
Contributor

Not stale

@elliotmjackson elliotmjackson added the Wont Fix Out of scope of this project label Sep 30, 2022
@miparnisari miparnisari mentioned this pull request May 19, 2023
Closed
@Kernald
Copy link

Kernald commented Aug 3, 2023

@elliotmjackson would you mind explaining why this has been closed? Saying that bufbuild isn't interested in pursuing this would be at least good to know, if that's the reason, but the silence on this PR for almost a year (I know the ownership changed during this period) and then closing it without saying anything is a bit weird.

@miparnisari
Copy link
Author

miparnisari commented Jan 8, 2024 •
edited

@Kernald protovalidate, the next generation of this tool, supports custom validation using CEL expressions, and also custom error messages :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
Wont Fix Out of scope of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miparnisari @rmichela @Kernald @elliotmjackson @codyaray