Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filegroup for validate.proto #595

Merged
merged 2 commits into from Sep 19, 2022
Merged

Add filegroup for validate.proto #595

merged 2 commits into from Sep 19, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented May 19, 2022

In order to include this in rust sources this needs to be included
directly downstream. Ideally we had a simple proto library target we
could use instead, but the rust ecosystem is a bit bifurcated.

bazelbuild/rules_rust#915

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

snowp
snowp previously approved these changes May 19, 2022
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In order to include this in rust sources this needs to be included
directly downstream. Ideally we had a simple proto library target we
could use instead, but the rust ecosystem is a bit bifurcated.

bazelbuild/rules_rust#915

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@elliotmjackson elliotmjackson merged commit b3bc053 into bufbuild:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants