New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protoc-gen-start dependency and add filepath.ToSlash() to fix #611 #612
Conversation
…ufbuild#611 Signed-off-by: Tiernan Messmer <tiernan.messmer@jcu.edu.au>
a66d8be
to
55d3f64
Compare
Looks like the build is failing due to some unrelated python protoc version issues? As far as I can tell my PR is fine. Hesitant to regenerate files that are unrelated to the PR and pollute the commits. |
Signed-off-by: Elliot Jackson <elliot@elliotmjackson.com>
Hi @nvx, thanks for your patience with this PR. I don't quite understand whats happening here...
we have a replace all func to create the path, and a |
#611 describes the issue that this PR fixes. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
It is worth noting, i have upgraded PGS so this issue is likely already solved in v0.6.8 |
I noticed that, and updating PGS is also needed, but I found just updating PGS wasn't enough, the ToSlash change is also needed. |
Required more than just the dependency update, also had to add in filepath.ToSlash() to fix the module parameter issue.