Fix indentation of python templates with ignore_empty fields inside oneof #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Fish <jfish@pinterest.com>
eleduardo
pushed a commit
to eleduardo/protoc-gen-validate
that referenced
this pull request
Aug 29, 2022
Signed-off-by: James Fish <jfish@pinterest.com> Signed-off-by: James Fish <jfish@pinterest.com> Signed-off-by: Eduardo Solis <eduardo.solis@mica.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ignore_empty used by a field inside a oneof then the generated python code was invalid. This is fixed by removal of the whitespace removal in the template to ensure if clause goes onto newline with base indentation.
Signed-off-by: James Fish jfish@pinterest.com