Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retract accidentally published versions #660

Merged
merged 1 commit into from Sep 29, 2022
Merged

Retract accidentally published versions #660

merged 1 commit into from Sep 29, 2022

Conversation

elliotmjackson
Copy link
Contributor

@elliotmjackson elliotmjackson commented Sep 29, 2022 •
edited

Outlined in #655

A number of versions were created inadvertently whilst attempting to resolve the maven relocation. This has negatively affected our golang community.

Retracting based on modules documentation:

consider a case where the author of module example.com/m publishes version v1.0.0 accidentally. To prevent users from upgrading to v1.0.0, the author can add two retract directives to go.mod, then tag v1.0.1 with the retractions.

retract (
    v1.0.0 // Published accidentally.
    v1.0.1 // Contains retractions only.
)

When a user runs go get example.com/m@latest, the go command reads retractions from v1.0.1, which is now the highest version. Both v1.0.0 and v1.0.1 are retracted, so the go command will upgrade (or downgrade!) to the next highest version, perhaps v0.9.5.

Versions 0.6.9 through 0.6.12(to be created with this PR) will be retracted.

Signed-off-by: Elliot Jackson 13633636+ElliotMJackson@users.noreply.github.com

@elliotmjackson
Retract accidentally published versions
6f7bb35 
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
joshcarp
joshcarp approved these changes Sep 29, 2022
View reviewed changes
Copy link

@joshcarp joshcarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMGT

@elliotmjackson elliotmjackson merged commit a86024e into main Sep 29, 2022
@elliotmjackson elliotmjackson deleted the ElliotMJackson-patch-1 branch September 29, 2022 19:13
mariogao pushed a commit to mariogao/protoc-gen-validate that referenced this pull request Sep 30, 2022
@elliotmjackson
Retract accidentally published versions (bufbuild#660)
8e669f0 
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: UT002324 <gaohaiyang@uniontech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcarp joshcarp joshcarp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elliotmjackson @joshcarp