Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Allow linking against external mbedtsl #90

Open
werdahias opened this issue May 13, 2023 · 3 comments
Open

[FR] Allow linking against external mbedtsl #90

werdahias opened this issue May 13, 2023 · 3 comments

Comments

@werdahias
Copy link

Hi,

I started packaging this library for debian as prerequisite for openrgb. I encountered a few issues stemming from the embedding dependencies. No package in debian should depend/ship external libraries.

  • json.hpp : Could you maybe add a check to find the system version first, then defaulting to the included copy ?
  • mbed-tls: same issue basically. Otherwise I get the following warnings during the build:
dpkg-shlibdeps: warning: symbol mbedtls_ctr_drbg_random used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_entropy_func used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_timing_set_delay used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_timing_get_delay used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_x509_crt_init used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_entropy_free used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_ctr_drbg_init used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_entropy_init used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_ctr_drbg_seed used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries
dpkg-shlibdeps: warning: symbol mbedtls_ctr_drbg_free used by debian/libhueplusplus-dev/usr/lib/libhueplusplusshared.so found in none of the libraries

because the mbdedtls library from debian isn't picked up (and linked).

The tests aren't buildable offline either. I'd appreciate if you could employ a similar check because gtest and gmock are both in debian.

@Jojo-1000
Copy link
Collaborator

Hi, I implemented find_package for external libraries on the external-deps branch.
Could you please test that it correctly links to the external dependencies? I only tested that it still works without installed libraries.

@werdahias
Copy link
Author

werdahias commented May 17, 2023

awesome, thank you! Unfortunately the version of mbedtls in debian is to old so I can't test the build. Once that gets updated I'll report back.

@werdahias
Copy link
Author

since mbedtls 3.x is available in debian I will test this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants